Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for QML #361

Closed
1 task done
mapau opened this issue Dec 28, 2020 · 4 comments
Closed
1 task done

Support for QML #361

mapau opened this issue Dec 28, 2020 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mapau
Copy link
Contributor

mapau commented Dec 28, 2020

QML

https://doc.qt.io/qt-5/qmlapplications.html

Logo

https://github.com/QMLCommunity

Upstream support

  • tokei supports this language
@mapau mapau added enhancement New feature or request good first issue Good for newcomers labels Dec 28, 2020
@mapau
Copy link
Contributor Author

mapau commented Dec 28, 2020

Hi, I added the qml support to language.rs file to my fork
https://github.com/mapau/onefetch/tree/feature/add-qml-support

https://github.com/Aaronepower/tokei already detects the qml files only the mapping in onefetch is missing.

Would be my first contribution to any GitHub Project.

@spenserblack
Copy link
Collaborator

Hi, I added the qml support to language.rs file to my fork

Great! Would you like to make a pull request?

@mapau
Copy link
Contributor Author

mapau commented Dec 28, 2020

#362

Didn't know about the cargo test. Sorry it's my first steps with rust and the tools around it.

I'll fix the ascii file and Update the PR, or should I create a new pull-request?

@o2sh
Copy link
Owner

o2sh commented Dec 28, 2020

Didn't know about the cargo test. Sorry it's my first steps with rust and the tools around it.

You're doing great! looking forward to merge your PR 👍

I'll fix the ascii file and Update the PR, or should I create a new pull-request?

Just update it.

@o2sh o2sh closed this as completed Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants