Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability enhancement: "Good news" feedback is returned like an error when a defined custom search API returns something #959

Closed
wrigleyDan opened this issue Feb 27, 2024 · 0 comments · Fixed by #963

Comments

@wrigleyDan
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When defining a custom search API endpoint and the response cannot be parsed appropriately by the Javascript mapping function the following message is shown to the user:
image

From a usability point of view it is not ideal that this partially successful message ("Good news") is shown as an error.

Describe the solution you'd like
Not being a UX expert I'm suggesting two options:

  1. either show the whole message in yellow instead of red as there is something going in the right direction (there is a response) but not all is working (the Javascript code needs some love)
  2. split the message in two parts, showing the part that is good in green and the part that is bad in red.

Describe alternatives you've considered

Additional context
Reproduction:

image
Proxy Requests activated

@epugh epugh linked a pull request Feb 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant