Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OAuth providers (Github) #188

Closed
gregoryduckworth opened this issue Aug 13, 2020 · 8 comments · Fixed by #280
Closed

Add OAuth providers (Github) #188

gregoryduckworth opened this issue Aug 13, 2020 · 8 comments · Fixed by #280
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@gregoryduckworth
Copy link

gregoryduckworth commented Aug 13, 2020

Is your feature request related to a problem? Please describe.
Rather than having multiple passwords to remember, it would be nice if there was the ability to login with providers such as Github.

Describe the solution you'd like
Github OAuth implemented so user management could be done with that.

Describe alternatives you've considered
Having the current implementation and having to remember passwords.

Additional information
Having the ability to use something like OmniAuth would allow multiple providers to be used.

@epugh
Copy link
Member

epugh commented Aug 24, 2020

@gregoryduckworth thank you for opening this issue.

I agree that having more flexible authentication options would be great. Today you can't authenticate via just the API, which means you have to click through the GUI. Hence the awkward lines here in AgentQ: https://github.com/o19s/agent_q/blob/master/lib/agent_q.rb#L30.

Doing this isn't on my roadmap, but I'd love to see the addition to Quepid!

@stale
Copy link

stale bot commented Nov 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 22, 2020
@epugh
Copy link
Member

epugh commented Nov 23, 2020

Ironically, when stalebot tagged this, is the same weekend I finally made progress on Rails upgrade from 4.2 --> 5. We use Devise for user auth, and it has a number of "providers" including oauth. We need to upgrade Rails in order to open the door to using the newer Devise code for both features like this, and what I am driving for, the ability to invite people to teams in Quepid who haven't yet signed up!

@stale stale bot removed the wontfix This will not be worked on label Nov 23, 2020
@gregoryduckworth
Copy link
Author

Ironically, when stalebot tagged this, is the same weekend I finally made progress on Rails upgrade from 4.2 --> 5. We use Devise for user auth, and it has a number of "providers" including oauth. We need to upgrade Rails in order to open the door to using the newer Devise code for both features like this, and what I am driving for, the ability to invite people to teams in Quepid who haven't yet signed up!

That is great to hear @epugh!

@epugh
Copy link
Member

epugh commented Dec 18, 2020

Hey @gregoryduckworth I wanted to ping you about your bandwidth/energy/interest on potentially adding this? I'm going to be merging in PR #256 and then #259 soon. This would set you up to do the oAuth providers work if you were interested?

@epugh
Copy link
Member

epugh commented Feb 19, 2021

@gregoryduckworth I wanted to let you know that those two tickets were merged, and if you wanted to add the oAuth support, that is now doable now that we have Rails 5 live!

@epugh epugh mentioned this issue Mar 5, 2021
9 tasks
@epugh epugh linked a pull request Mar 5, 2021 that will close this issue
9 tasks
@epugh epugh added the enhancement New feature or request label Apr 10, 2021
@epugh
Copy link
Member

epugh commented Apr 10, 2021

I've started simplifying the login pages and the user profile pages to not touch the Angular app front end, but to be plain vanilla Rails / server side HTML. Once that is done, I'll probably come back and finish adding #280

@stale
Copy link

stale bot commented Jul 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants