Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TS config to allow extending CircuitValue class with no constructor #228

Closed
ymekuria opened this issue Jun 30, 2022 · 0 comments
Closed

Update TS config to allow extending CircuitValue class with no constructor #228

ymekuria opened this issue Jun 30, 2022 · 0 comments
Assignees
@ymekuria

Comments

@ymekuria
Copy link
Collaborator

ymekuria commented Jun 30, 2022 •
edited
Loading

Description

A pending PR in SarkyJS makes some changes to SnarkyJS. If it lands, some changes should be made to the CLI.

Developers not using a constructor on classes that extend CircuitValue will get a TS error on their props:

"Property has no initializer and is not definitely assigned in the constructor".

This can be fixed locally by adding a ! to the prop, e.g. @prop value!: Field. it can also be fixed globally in the project by adding a TS config option.
@ymekuria ymekuria self-assigned this Jul 6, 2022
@ymekuria ymekuria changed the title Update TS config to allow extending CircuitValue class with no custructor Update TS config to allow extending CircuitValue class with no constructor Jul 6, 2022
@ymekuria ymekuria mentioned this issue Jul 7, 2022
Merged
@ymekuria ymekuria closed this as completed Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ymekuria ymekuria

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ymekuria