Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: a way to specify angles in degrees with minutes #119

Open
serhiy-yevtushenko opened this issue Jan 11, 2025 · 3 comments
Open
Labels
enhancement New feature or request question Further information is requested

Comments

@serhiy-yevtushenko
Copy link
Contributor

Is there an official way in the library to set value of Angular unit with minutes?

Or the correct way is to use something like:

def angle_with_minutes(degree_whole_part: int, minutes: int)->Angular:
      return Angular.MOA(degree_whole_part*60+minutes)

Is there some Angular unit which allows specifying seconds of degree?

@o-murphy
Copy link
Owner

o-murphy commented Jan 12, 2025

Not yet, u can add it to your MR, I think it quite simple

@o-murphy
Copy link
Owner

Is there some Angular unit which allows specifying seconds of degree?

Why did u not use it like: Angular.Degree(d+m/60+s/3600)?
Or in your approach Angular.MOA(d*60+m+s/60)

@serhiy-yevtushenko
Copy link
Contributor Author

It will work out till all values are positive. But if degree is a negative one, then one needs a more complicated system (for checking validity of inputs and as well for computing the correct angle.

@o-murphy o-murphy added enhancement New feature or request question Further information is requested labels Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants