Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum frame count threshold for alarms #509

Open
lennartkoopmann opened this issue Sep 2, 2021 Discussed in #508 · 2 comments
Open

Minimum frame count threshold for alarms #509

lennartkoopmann opened this issue Sep 2, 2021 Discussed in #508 · 2 comments
Assignees
Milestone

Comments

@lennartkoopmann
Copy link
Member

Introduce an optional minimum frame count threshold for alarms that might trigger to early if only a single frame can cause them.

Discussed in #508

Originally posted by kruthoff September 2, 2021
I see false alarms (UNEXPECTED_CHANNEL_BEACON, UNEXPECTED_CHANNEL_PROBERESP) which are based on a single frame. Is it possible to generate alarms only at a higher number of frames? Or doesn't this make sense?

I see false alarms (BEACON_RATE_ANOMALY) for spikes for peaks that occur very rarely.
Is it possible to avoid alarms for such spikes?

@lennartkoopmann lennartkoopmann added this to the 1.x milestone Sep 2, 2021
@timn
Copy link

timn commented Nov 3, 2021

This would be very useful indeed. My use case is slightly different: the APs will hop channels every now and then to optimize signal. I have a script which runs priodically to retrieve these and if changed updates the nzyme config to the newly expected channels. Now there is a race between the AP changes the channel and the update script being run.

Another way which may be interesting to set is if the problem persists for some minimum duration, e.g., 2 minutes (so it is independent of the number of frames received but means that a problem must persist at least for some specific time).

Yet another option is to externalize the decision by enabling an external program/script to be run ("trigger alert?"). In my case I could query the AP and tell if the channel is expected, for fingerprints one could use a sqlite db to check if a problem already persists for some time. I think this would be very flexible and useful, and at the same time fairly easy to implement.

@lennartkoopmann lennartkoopmann modified the milestones: 1.x, 1.2.0 Nov 7, 2021
@lennartkoopmann
Copy link
Member Author

Thank you! Appreciate the additional ideas.

@lennartkoopmann lennartkoopmann modified the milestones: 1.2.0, 1.x Nov 21, 2021
@lennartkoopmann lennartkoopmann modified the milestones: 1.x, 2.0.0 Mar 22, 2022
@lennartkoopmann lennartkoopmann self-assigned this Dec 4, 2022
@lennartkoopmann lennartkoopmann moved this to 📋 Backlog in nzyme v2.0 Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants