Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script does not seem to work with (at least) frugal #10

Open
kouze opened this issue Jan 7, 2025 · 2 comments
Open

Script does not seem to work with (at least) frugal #10

kouze opened this issue Jan 7, 2025 · 2 comments
Assignees

Comments

@kouze
Copy link

kouze commented Jan 7, 2025

Hi guys,

first of all thanks for this useful script. It is working fine for omicron based servers (usenetserver, eweka, newshosting).
Unfortunately, the method used to check the existence of the articles is failing with frugal server (main one, I used the ipv6 one but I guess the result will be the same with ipv4) as, while frugal's server confirms the article is avaible, it is not once you really download the articles.
It seems you are using STAT as a default (hardcoded) CHECK_METHOD. I tried changing the parameter to HEAD but this is not as obvious as additional coding would be required, hence I can't confirm if HEAD method would work for frugal as well.
Would you be able to do some testing on frugal's servers ?

In addition, on my side I've written an additional script that will be run just after yours to stop the potential download and mark the NZBID as good or bad, as one of my purpose of using the Completion script is only to check the data and not download it.
Unfortunately: I can't set the the forcefailure = No as it is completely stopping further processing to happen
Forcefailure = Yes would work if I let the download of the 2 files to finish, but it is a waste of time as we already know that the NZB is dead.
Hence: would you be OK to implement a custom parameter at the end of force_failure to indicate that the Completion Check has failed?Something like: NZBGet.editqueue("GroupSetParameter", 0, "CompletionCheck=False", nzb_id)

Then in my additional script I could clearly know that the completion script either was a success or not, even without downloading anything :)
If not possible or sounds a bad idea, np, I'll add the line manually :)

Thanks

@dnzbk dnzbk self-assigned this Jan 8, 2025
@dnzbk
Copy link
Collaborator

dnzbk commented Jan 17, 2025

Hi @kouze,

Thank you for reporting this issue and for the helpful suggestions!
This highlights an area I need to improve even NZBget itself. I'm going to take a deep dive into all of this by nzbget v25.

@kouze
Copy link
Author

kouze commented Jan 23, 2025

Hi @dnzbk

sure take your time on this :)

Thanks
kouze

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants