From 0d038a22c8fc3134724071f3f19bd3d523827e1e Mon Sep 17 00:00:00 2001 From: Jared McDonald Date: Mon, 6 Mar 2017 21:06:51 -0500 Subject: [PATCH 1/2] add placeholders, pending issue creation --- README.md | 2 ++ docs/kytConfig.md | 3 +++ packages/kyt-core/utils/kytConfig.js | 5 +++++ 3 files changed, 10 insertions(+) diff --git a/README.md b/README.md index b9e2adec0..a55b820dd 100644 --- a/README.md +++ b/README.md @@ -42,6 +42,8 @@ Developers design their own architecture, choosing the tools they need for rende For advanced use cases, kyt enables developers to add additional tools and configuration. See our [config override instructions](/docs/kytConfig.md#modifywebpackconfig) for details, and our [recipes](/docs/Recipes.md) for examples. +_In an attempt to gather feedback to set future priorities, we're running a brief user survey asking: [what are you using `modifyWebpackConfig` for?](https://github.com/NYTimes/kyt/issues/TODO)_ + ## Setting up a kyt project kyt-cli is a utility for bootstrapping kyt projects. It can be installed globally and run to create a new project or integrate kyt with an existing project. diff --git a/docs/kytConfig.md b/docs/kytConfig.md index 5adea419b..42b004d9d 100644 --- a/docs/kytConfig.md +++ b/docs/kytConfig.md @@ -21,6 +21,9 @@ and export an object with the following options. ## modifyWebpackConfig + +_In an attempt to gather feedback to set future priorities, we're running a brief user survey asking: [what are you using `modifyWebpackConfig` for?](https://github.com/NYTimes/kyt/issues/TODO)_ + `modifyWebpackConfig` is an optional callback you can define to edit the Webpack config for each part of development. This allows you to add new babel-plugins, modify Webpack loaders, etc. diff --git a/packages/kyt-core/utils/kytConfig.js b/packages/kyt-core/utils/kytConfig.js index 4876bff84..b7b68c4bd 100644 --- a/packages/kyt-core/utils/kytConfig.js +++ b/packages/kyt-core/utils/kytConfig.js @@ -41,6 +41,11 @@ module.exports = (optionalConfig) => { config = mergeAll([{}, baseConfig, config]); + if (typeof config.modifyWebpackConfig === 'function') { + logger.info('What are you doing in your modifyWebpackConfig?'); + logger.info('Let us know: https://github.com/NYTimes/kyt/issues/TODO'); + } + // Create default identity functions for modify functions ['modifyWebpackConfig', 'modifyJestConfig'].forEach((m) => { if (typeof config[m] !== 'function') { From 00d4c77163471a1acf08597f8229ea5199c59dc8 Mon Sep 17 00:00:00 2001 From: Jared McDonald Date: Tue, 7 Mar 2017 23:43:05 -0500 Subject: [PATCH 2/2] add issue number --- README.md | 2 +- docs/kytConfig.md | 2 +- packages/kyt-core/utils/kytConfig.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index a55b820dd..fe66174a4 100644 --- a/README.md +++ b/README.md @@ -42,7 +42,7 @@ Developers design their own architecture, choosing the tools they need for rende For advanced use cases, kyt enables developers to add additional tools and configuration. See our [config override instructions](/docs/kytConfig.md#modifywebpackconfig) for details, and our [recipes](/docs/Recipes.md) for examples. -_In an attempt to gather feedback to set future priorities, we're running a brief user survey asking: [what are you using `modifyWebpackConfig` for?](https://github.com/NYTimes/kyt/issues/TODO)_ +_In an attempt to gather feedback to set future priorities, we're running a brief user survey asking: [what are you using `modifyWebpackConfig` for?](https://github.com/NYTimes/kyt/issues/432)_ ## Setting up a kyt project diff --git a/docs/kytConfig.md b/docs/kytConfig.md index 42b004d9d..fe4265d1d 100644 --- a/docs/kytConfig.md +++ b/docs/kytConfig.md @@ -22,7 +22,7 @@ and export an object with the following options. ## modifyWebpackConfig -_In an attempt to gather feedback to set future priorities, we're running a brief user survey asking: [what are you using `modifyWebpackConfig` for?](https://github.com/NYTimes/kyt/issues/TODO)_ +_In an attempt to gather feedback to set future priorities, we're running a brief user survey asking: [what are you using `modifyWebpackConfig` for?](https://github.com/NYTimes/kyt/issues/432)_ `modifyWebpackConfig` is an optional callback you can define to edit the Webpack config for each part of development. This allows you to add new babel-plugins, modify Webpack loaders, etc. diff --git a/packages/kyt-core/utils/kytConfig.js b/packages/kyt-core/utils/kytConfig.js index b7b68c4bd..a500a587b 100644 --- a/packages/kyt-core/utils/kytConfig.js +++ b/packages/kyt-core/utils/kytConfig.js @@ -43,7 +43,7 @@ module.exports = (optionalConfig) => { if (typeof config.modifyWebpackConfig === 'function') { logger.info('What are you doing in your modifyWebpackConfig?'); - logger.info('Let us know: https://github.com/NYTimes/kyt/issues/TODO'); + logger.info('Let us know: https://github.com/NYTimes/kyt/issues/432'); } // Create default identity functions for modify functions