Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaborating on implementing a Github C++ API #2

Open
daminetreg opened this issue Sep 9, 2019 · 7 comments
Open

Collaborating on implementing a Github C++ API #2

daminetreg opened this issue Sep 9, 2019 · 7 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@daminetreg
Copy link
Member

Dear @tony84727, @durdyev and @TanninOne,

I've created last year my own Github API implementation as I couldn't find yours otherwise I would have contributed back to your implementations.

Today I thought : "well if I cannot find my lib on google after 1 year, then it must be that there are existing libs and that they cannot be found as well !"

Mine (used in nxxm & asciidochub) :
https://github.com/nxxm/gh

So I searched with the github search and could find yours :
https://github.com/TanninOne/githubpp
https://github.com/tony84727/github-client-cpp
https://github.com/durdyev/githubapicpp

Now we are in a situation where we have like 4 incomplete api implementation.

Would you be interested in collaborating and trying to implement the github api fully ?

We could, following how much we want to put effort into, also go for the graphql implementation, there are no graphql client for the moment in C++ so perhaps this might be something we would like to do ?

I just start the discussion to see if we can find any synergy between us. Would you be interested to collaborate ? 😀

Best regards !

@daminetreg daminetreg added enhancement New feature or request question Further information is requested labels Sep 9, 2019
@TanninOne
Copy link

TanninOne commented Sep 9, 2019

Hi daminetreg and thank you for reaching out!
My library was written for a very specific use case and is such quite limited and Qt-centric.

Unfortunately I'm no longer working on that project and currently barely work with c++ at all. My project has been adopted by others though, maybe you can get them on board: https://github.com/ModOrganizer2/githubpp

@daminetreg
Copy link
Member Author

Thanks for relating to the users, you were using the releases api to install updates ?

@Silarn and @isanae are you interested in building a common github API implementation, or tools around the github API ?

@isanae
Copy link

isanae commented Sep 9, 2019

You seem to be developing a general purpose library to access the Gihub API. Our library really isn't a library at all, it's a simple way to get the list of releases that is then processed within Mod Organizer to check for updates.

I don't foresee any need for MO to have a more comprehensive system to access Github, so I doubt that we would participate in this project as part of MO's development.

As for myself personally, I appreciate the offer, but what little free time I have is currently spent on MO.

@daminetreg
Copy link
Member Author

I actually do something similar to auto-upgrade apps if there is a newer release in github releases and replace the app binary with the new one ans relaunch it https://github.com/nxxm/upgrd .

Thanks for considering and taking the time to reply ! 🙂🤗

Happy hacking !

@tony84727
Copy link

Hi, @daminetreg thanks for reaching out. I'm appreciated. My use case for the API no longer exists, so I archived that project. I do have free time and willing to contribute, but sometimes I just spend those time on playing games 😄 . So I can't make the promise to contribute regularly.

@daminetreg
Copy link
Member Author

Hi, @daminetreg thanks for reaching out. I'm appreciated. My use case for the API no longer exists, so I archived that project. I do have free time and willing to contribute, but sometimes I just spend those time on playing games 😄 . So I can't make the promise to contribute regularly.

You are very welcome @tony84727 ! 😄 Great. if you are motivated by doing any github related tool just contact me then or take some issue up here I'll help. I'll start the graphql stuffs I think ASAP, so don't hesitate to pick in it when you want to have fun coding !

Btw which games do you play ?

@tony84727
Copy link

Thank you. So the plan is to implement a generic graphql that support schemas, then use the client to implement Github client?

(I play mostly Minecraft and Heroes of Storm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants