Rename MacOS Helpers #930
Replies: 1 comment 3 replies
-
|
Changing the copyright string is much different than renaming the helpers. I successfully tested renaming the copyright string. When I tried renaming the helpers, it fails. You can even find code that used to do this in the nw-builder commit history. 😁 |
Beta Was this translation helpful? Give feedback.
-
|
Did you rename the Helpers and update the Plist values which reference those Helpers? |
Beta Was this translation helpful? Give feedback.
-
|
No, I don't think I updated Plist values. I believe we were only renaming the files and trying This was part of the conversation: #705 (comment) The related NW.js issue: nwjs/nw.js#7253 If you look at the nw-builder code from around the time of the above issue/comment, we had a bunch of this implemented but I believe you later removed it. |
Beta Was this translation helpful? Give feedback.
-
|
Awesome, I'll come up with a PR soon |
Beta Was this translation helpful? Give feedback.
-
Refs: #897 (comment)
Refs: #705
@zkrige I don't have a MacOS to test this on. Are you up for creating a PR to test this?
Beta Was this translation helpful? Give feedback.
All reactions