Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Windows 10 taskbar icon points to non-existent "nw.exe" instead of renamed NWjs exe #8253

Open
LostBeard opened this issue Feb 21, 2025 · 0 comments

Comments

@LostBeard
Copy link

LostBeard commented Feb 21, 2025

On Windows 10 taskbar icon points to non-existent "nw.exe" instead of renamed NWjs exe.

Issue #8227 was "fixed" in a way that created this issue. I would have re-opened that issue but it does not allow it, and technically, based on its title, it is fixed because I stated in the bug title, it should point to nw.exe.

It looks like a possible fix for this issue and #8227 was submitted and then almost immediately replaced with code that requires NWjs to never be renamed or it will fail.

@ayushmanchhabra and @rogerwang: You guys were involved in both commits. Why was the fix replaced?

This commit should fix issue #8227 and this issue and was submitted 2 weeks ago:
nwjs/chromium.src@80fd1a4

This commit switched back to using a statically named exe (nw.exe) that probably won't exist due to common usage:
nwjs/chromium.src@3190d61

Is there a better spot to fix this? I think most users are renaming nw.exe so why is referencing a statically named nw.exe preferred here over getting the exe name at runtime?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant