You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On Windows 10 taskbar icon points to non-existent "nw.exe" instead of renamed NWjs exe.
Issue #8227 was "fixed" in a way that created this issue. I would have re-opened that issue but it does not allow it, and technically, based on its title, it is fixed because I stated in the bug title, it should point to nw.exe.
It looks like a possible fix for this issue and #8227 was submitted and then almost immediately replaced with code that requires NWjs to never be renamed or it will fail.
This commit switched back to using a statically named exe (nw.exe) that probably won't exist due to common usage: nwjs/chromium.src@3190d61
Is there a better spot to fix this? I think most users are renaming nw.exe so why is referencing a statically named nw.exe preferred here over getting the exe name at runtime?
The text was updated successfully, but these errors were encountered:
On Windows 10 taskbar icon points to non-existent "nw.exe" instead of renamed NWjs exe.
Issue #8227 was "fixed" in a way that created this issue. I would have re-opened that issue but it does not allow it, and technically, based on its title, it is fixed because I stated in the bug title, it should point to
nw.exe
.It looks like a possible fix for this issue and #8227 was submitted and then almost immediately replaced with code that requires NWjs to never be renamed or it will fail.
@ayushmanchhabra and @rogerwang: You guys were involved in both commits. Why was the fix replaced?
This commit should fix issue #8227 and this issue and was submitted 2 weeks ago:
nwjs/chromium.src@80fd1a4
This commit switched back to using a statically named exe (
nw.exe
) that probably won't exist due to common usage:nwjs/chromium.src@3190d61
Is there a better spot to fix this? I think most users are renaming
nw.exe
so why is referencing a statically namednw.exe
preferred here over getting the exe name at runtime?The text was updated successfully, but these errors were encountered: