Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NWjs crashes sometimes on Windows when using menu.popup #4697

Closed
iteufel opened this issue Apr 9, 2016 · 5 comments
Closed

NWjs crashes sometimes on Windows when using menu.popup #4697

iteufel opened this issue Apr 9, 2016 · 5 comments
Assignees
Milestone

Comments

@iteufel
Copy link
Contributor

iteufel commented Apr 9, 2016

NWjs crashes sometimes on Windows when using menu.popup .

The problem appears since the fix #4593.

dmp.zip
menu-test.zip

@rogerwang rogerwang added this to the 0.13.x milestone Apr 9, 2016
@rogerwang
Copy link
Member

I guess the menu is GCed before the crash. To verify this idea, does holding a reference to the menu object help?

@rogerwang rogerwang self-assigned this Apr 9, 2016
@iteufel
Copy link
Contributor Author

iteufel commented Apr 9, 2016

Yes it helps.

@rogerwang
Copy link
Member

@fritx
Copy link

fritx commented Nov 23, 2016

Same here...
I'm using nwjs 0.14.7-sdk (upgraded from 0.12.3), in Windows (MacOS is fine) the app crashes every time I run the following code:

var gui = require('nw.gui');
var menu = new gui.Menu();
var item = new gui.MenuItem({ label: 'Item A' });
menu.append(item);
menu.popup(10, 10); // <---- crash

@fritx
Copy link

fritx commented Nov 23, 2016

Both of nw 14.7, 18.7 and 18.8 crash with the same thing Check failed: atom 87
Related issue: #5331

Eventually I found that if I use "Aero Visual Styles", it doesn't crash.
But I have to make it work with "Windows 7 Basic" and "Windows XP" Styles.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants