-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window.open callback returns undefined for new window #4188
Comments
I can confirm this issue with latest nightly build (2016-01-08) on MacOS |
@rogerwang I see this problem every time I execute this on latest nwjs 0.13 beta3 (Jan 12)
any news about that? |
same problem with beta4 on windows . new_win is randomly indefined |
same on beta4 and beta5 |
oh, I'm using new_win = nw.Window.open(url, options), btw, an expecting the same as I'd get from window.open() in a browser ... |
Does this happen only with remote sites? It should have been fixed in the nightly build. |
@rogerwang I had this problem even with local pages. I will test next build ASAP |
Hello @rogerwang Any workaround for the moment? |
tested on nwjs 0.14... bug is still there =( |
It works for me because we have a test case for this scenario: https://github.com/nwjs/nw.js/tree/nw13/test/remoting/open-remote See test.py for the content of index.html it generates on the fly. Is it different from yours? |
I have the same problem with the version 0.13.0-rc3sdk , but it's not all time ... maybe one time for 10 tests . |
@thib3113 could you please upload a sample for the random error? Our test case 'open-remote' never fail so I cannot reproduce it. |
I juste use this : gui.Window.open('http://www.XXXXX.com/forum/notifications.html', {
position: 'center',
width: screen.availWidth,
height: screen.availHeight,
show : false,
},
function(cWindows){
cWindows.on('error', function(a,b,c){
debugger;
});
}); With devtools open, and some time i see
(not sure is the exact error message, but it is like the error) But, i don't know if the problem is : the website, my connection (I use my phone connection, so lot of connection problems), or other ... |
@rogerwang any news about this issue? In your test case you don't have any "node-remote". Maybe try to set it and test again. |
nw 0.13.0 |
should be fixed within this build: http://dl.nwjs.io/live-build/05-03-2016/nw14-d154648-1208bce-756e507-24751d8/v0.14.3/ |
In 0.14.4 the problem is still present. |
I found the solution in 0.14.4, i am changed the approach: window.opener.closeSplashscreen(); |
any update? I also meet this issue and don't know how to workaround?
|
@walton007 what is your nwjs version? did you try with 0.17? |
I reproduce it use remote url and set dns to invalid ip. nw.window.open callback a undefined |
same problem for me on winddows
|
For me, the undefined nw.Window.open('about:blank', {}, function(win) {
if(win) {
console.log("win is no longer undefined!");
}
); |
I am having this problem, and it doesn't even work with |
nw.Window.open('https://github.com', {}, function(new_win) {
console.log(new_win);
});
new_win is randomly undefined. So if you run the code lets say 5 times. You might get undefined 2 times
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: