Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow turning on / off frame after app / window is open #2390

Closed
adam-lynch opened this issue Sep 25, 2014 · 2 comments
Closed

Allow turning on / off frame after app / window is open #2390

adam-lynch opened this issue Sep 25, 2014 · 2 comments
Labels

Comments

@adam-lynch
Copy link

See #2387.

Since the experience is different per platform (i.e. fine on Windows), then a user might use the native frame on Mac and a custom HTML frame / controls on other platforms ( at least until #2389 is there with enough flexibility). That would mean that the user would have to build the app more than once (with node-webkit-builder, etc.) because the app's manifest would be different.

Therefore, we should be able to toggle the frame on the app / a window, at any point.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@1j01
Copy link

1j01 commented May 17, 2015

👍 and I don't plan on building my app any time soon, and just distributing it through npm, as it's a somewhat npm-focused app anyways. So separate builds is not a solution for me.
What I've done in absence of the ability to toggle the frame on the fly is relaunch the window on startup, unless it's already frameless, with options from the package.json and options overridden to turn off the frame. I can't directly check whether the window has a frame or not because there's no API for that but luckily I also wanted to toggle transparency along with the frame, so I was able to use that as a check for whether it's been relaunched already.
It's a bit more complicated than it ought to be 😄

@stale
Copy link

stale bot commented Oct 9, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 9, 2017
@stale stale bot closed this as completed Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants