From f4a68d04e9dc0c3afa660cf4faea906d8f314572 Mon Sep 17 00:00:00 2001 From: Gary Kacmarcik Date: Mon, 23 Jul 2018 17:23:05 +0000 Subject: [PATCH] [KeyboardMap] Enable navigator.keyboard.getLayoutMap() on Stable. Launch bug (w/ approvals): crbug.com/831743 Intent 2 ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V2xR7cucnOA Bug: 832811, 831743 Change-Id: I24d2f49e82b5afe1dd668dc57e0ceb98af36e205 Reviewed-on: https://chromium-review.googlesource.com/1141104 Reviewed-by: Alex Russell Commit-Queue: Gary Kacmarcik Cr-Original-Commit-Position: refs/heads/master@{#576796}(cherry picked from commit 4fcc638ec7f175167fcc9a00233c96cd7c22eda7) Reviewed-on: https://chromium-review.googlesource.com/1147040 Reviewed-by: Gary Kacmarcik Cr-Commit-Position: refs/branch-heads/3497@{#16} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} --- .../webexposed/global-interface-listing-expected.txt | 12 ++++++++++++ .../blink/renderer/modules/keyboard/keyboard.idl | 1 - .../renderer/platform/runtime_enabled_features.json5 | 2 +- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt b/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt index 6c0b8a19e797a..93e734c5cb3e8 100644 --- a/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt +++ b/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt @@ -3588,6 +3588,7 @@ interface IntersectionObserverEntry interface Keyboard attribute @@toStringTag method constructor + method getLayoutMap method lock method unlock interface KeyboardEvent : UIEvent @@ -3610,6 +3611,17 @@ interface KeyboardEvent : UIEvent method constructor method getModifierState method initKeyboardEvent +interface KeyboardLayoutMap + attribute @@toStringTag + getter size + method @@iterator + method constructor + method entries + method forEach + method get + method has + method keys + method values interface LinearAccelerationSensor : Accelerometer attribute @@toStringTag method constructor diff --git a/third_party/blink/renderer/modules/keyboard/keyboard.idl b/third_party/blink/renderer/modules/keyboard/keyboard.idl index c6e9af58d271b..86832c9d1d475 100644 --- a/third_party/blink/renderer/modules/keyboard/keyboard.idl +++ b/third_party/blink/renderer/modules/keyboard/keyboard.idl @@ -17,7 +17,6 @@ // Keyboard Map specification: https://wicg.github.io/keyboard-map/ [CallWith=ScriptState, - RuntimeEnabled=KeyboardMap, MeasureAs=KeyboardApiGetLayoutMap ] Promise getLayoutMap(); }; diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5 index 651d454b8dea6..933a133f9df33 100644 --- a/third_party/blink/renderer/platform/runtime_enabled_features.json5 +++ b/third_party/blink/renderer/platform/runtime_enabled_features.json5 @@ -636,7 +636,7 @@ }, { name: "KeyboardMap", - status: "experimental", + status: "stable", }, { name: "LangAttributeAwareFormControlUI",