Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run in terminal does not work if nwg-drawer started from a key binding #23

Closed
nwg-piotr opened this issue Sep 7, 2021 · 0 comments · Fixed by #24
Closed

run in terminal does not work if nwg-drawer started from a key binding #23

nwg-piotr opened this issue Sep 7, 2021 · 0 comments · Fixed by #24

Comments

@nwg-piotr
Copy link
Owner

The defaultStringIfBlank function added in #20 expects the os.Getenv("TERM") to be blank in order to return the fallback value. However, if we start the drawer from a key binding, the returned value is "linux", so this won't work.
nwg-piotr added a commit that referenced this issue Sep 7, 2021
@nwg-piotr
fix #23
f12be46
@nwg-piotr nwg-piotr mentioned this issue Sep 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix nodisplay, fix running in terminal nwg-piotr/nwg-drawer
1 participant
@nwg-piotr