Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed small typo afew to a few #2517

Merged
merged 1 commit into from
Sep 29, 2021
Merged

fixed small typo afew to a few #2517

merged 1 commit into from
Sep 29, 2021

Conversation

strouja
Copy link
Contributor

@strouja strouja commented Jun 4, 2021

I also gave more up to date versions for example of nvm install and nvm which as well as your pointer section
I love your project by the way.

I hope you like my minor suggestions. I thought it could be confusing to new people of node if we refer to such old versions that no one uses anymore.

also gave more up to date versions for example of  `nvm install` and `nvm which` as well as your pointer section
I love your project by the way.
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt it's remotely confusing - users know how numbers work - but it can't hurt to update them.

Left a few comments.

Copy link
Contributor Author

@strouja strouja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your changes @ljharb

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. merging this will have to wait until travis-ci fixes the issues it's having.

@ljharb ljharb merged commit 91bd22a into nvm-sh:master Sep 29, 2021
@strouja
Copy link
Contributor Author

strouja commented Sep 29, 2021

thanks for doing this, I'll delete the branch now

@strouja strouja deleted the patch-1 branch September 29, 2021 06:41
@ljharb ljharb mentioned this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants