Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[readme] Fix a typo #2512

Closed
wants to merge 1 commit into from
Closed

[readme] Fix a typo #2512

wants to merge 1 commit into from

Conversation

IamAfnanSk
Copy link

Fixed: typo in README.md

Fixed: typo in README.md
@IamAfnanSk IamAfnanSk requested a review from ljharb May 23, 2021 15:10
@IamAfnanSk
Copy link
Author

1 check still remains

@IamAfnanSk IamAfnanSk marked this pull request as draft May 23, 2021 15:11
@ljharb
Copy link
Member

ljharb commented May 23, 2021

That’s fine; it’s Travis having trouble. Once i get that fixed, I’ll land this.

@ljharb ljharb marked this pull request as ready for review May 23, 2021 15:43
@IamAfnanSk
Copy link
Author

Usually this don't take that much time? any idea what's happening?

@ljharb
Copy link
Member

ljharb commented May 26, 2021

@IamAfnanSk it's a problem on travis' side. hopefully you don't mind leaving this open until i resolve it with them.

@IamAfnanSk
Copy link
Author

Sure

@Abhra303
Copy link

In the README file, there is another mistake in the Troubleshooting on Linux . In the second line, the word "run" is repeated twice.
Alternatively, you can run *run* the following commands for the different shells on the command line:

@ljharb
Copy link
Member

ljharb commented Sep 29, 2021

@IamAfnanSk unfortunately it seems like you deleted your fork, so i can't rebase and land this. Any chance you could restore it?

@ljharb ljharb marked this pull request as draft September 29, 2021 05:30
@IamAfnanSk
Copy link
Author

@ljharb Hey! I don't have a copy locally and I also deleted from GitHub, so I think I won't be able to do so.

By any chance do you know about any other possibility?

@ljharb
Copy link
Member

ljharb commented Sep 29, 2021

@IamAfnanSk my hope was that you could make a new fork on github, and git checkout 03859aa && git checkout -b patch-1 && git push, and that github would reconnect it to the PR. if that doesn't work tho, then there's probably no better option than me just pulling in the change directly :-(

@IamAfnanSk
Copy link
Author

@ljharb I forked and tried git checkout 03859aa && git checkout -b patch-1 && git push but this doesn't seem to work.

fatal: reference is not a tree: 03859aa0de15d0835c9f85590bd25ea36f880fc2

@ljharb
Copy link
Member

ljharb commented Sep 30, 2021

Interesting; you could probably add this repo as a remote and fetch from it to get the sha, but that’s getting complicated. I’ll try to land the change directly.

@ljharb
Copy link
Member

ljharb commented Nov 1, 2021

Looks like this was fixed in 91bd22a / #2517.

@ljharb ljharb closed this Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants