Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm run tests-only command doesn't exist #3104

Closed
dewren99 opened this issue Apr 30, 2023 · 3 comments · Fixed by #3105
Closed

npm run tests-only command doesn't exist #3104

dewren99 opened this issue Apr 30, 2023 · 3 comments · Fixed by #3105

Comments

@dewren99
Copy link
Contributor

I've noticed that in the CONTRIBUTING.md it is mentioned to run either npm test or npm run tests-only for testing,
however npm run tests-only command isn't defined.
@ljharb
Copy link
Member

ljharb commented May 1, 2023

That's a good point; the text was copy-pasted from other repos, and this is one of the only ones I don't use that pattern on.

@dewren99
Copy link
Contributor Author

dewren99 commented May 1, 2023

Do you think it's worth opening a PR or should I close the issue?

@ljharb
Copy link
Member

ljharb commented May 1, 2023

To update the contributing file, yes, that’d be great thanks.

dewren99 added a commit to dewren99/nvm that referenced this issue May 1, 2023
@dewren99
[Docs] Remove unavailable testing script
bf431aa 
Fixes nvm-sh#3104
@dewren99 dewren99 mentioned this issue May 1, 2023
Merged
@ljharb ljharb closed this as completed in 0ebda7e May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Docs] Remove unavailable testing script dewren99/nvm
3 participants
@ljharb @dewren99 and others