Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update koi.json to use bs5 #365

Closed
ropalko opened this issue Apr 4, 2024 · 1 comment · Fixed by #366
Closed

Update koi.json to use bs5 #365

ropalko opened this issue Apr 4, 2024 · 1 comment · Fixed by #366
Labels
bug Something isn't working
Milestone
3.1.1

Comments

@ropalko
Copy link

ropalko commented Apr 4, 2024 •
edited
Loading

Describe the bug

The current koi.json files uses bs4 instead of bs5. When working with Koi, the framework assumes that "BS4" is used even though it is a BS5 skin.

Expected behavior

Skin should be labeled as BS5 Skin
@david-poindexter
Copy link
Member

Great catch!

@david-poindexter david-poindexter mentioned this issue Apr 5, 2024
Merged
6 tasks
@david-poindexter david-poindexter added the bug Something isn't working label Apr 5, 2024
@david-poindexter david-poindexter added this to the 3.1.1 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.1.1
Development

Successfully merging a pull request may close this issue.

Update koi.json to indicate Bootstrap 5 instead of Bootstrap 4 david-poindexter/nvQuickTheme
2 participants
@ropalko @david-poindexter