Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bold/italic emphasis syntax is not rendered in headlines #67

Closed
ourigen opened this issue Aug 19, 2021 · 5 comments
Closed

Bold/italic emphasis syntax is not rendered in headlines #67

ourigen opened this issue Aug 19, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@ourigen
Copy link
Contributor

ourigen commented Aug 19, 2021

Describe the bug

Emphasis syntax such as *bold*, /italic/, _underlined_, etc. don't seem to render in headlines. I take notes in bullets so I make use of bolded/italicized words in headlines often.

With the top level headline I can understand why bolding doesn't show since the entire headline is bolded. But italicizing doesn't work for all headlines and bolding doesn't work for subheadlines

Steps to reproduce

This is what I used in my example text

* This is a test: *bold* /italic/ _underlined_
** This is a test: *bold* /italic/ _underlined_
*** This is a test: *bold* /italic/ _underlined_
This is a test: *bold* /italic/ _underlined_

Expected behavior

For *bold*, /italic/, and _underlined_, I expected each word to render in the right face and be concealed (if the setting is set to true) even in headlines. The syntax properly shows and is concealed in normal text.

Emacs functionality

No response

Screenshots and recordings

github

OS / Distro

Arch Linux

Neovim version/commit

v0.6.0-dev

Additional context

No response

@ourigen ourigen added the bug Something isn't working label Aug 19, 2021
@kristijanhusak
Copy link
Member

This is currently really hard to achieve without defining bunch of new syntax hl groups to handle each headline level for specific headline color, which I want to avoid for now. If i would enable it, this is what it would look like:
screenshot
Once treesitter support is added, this should be an easily solvable issue.

@kristijanhusak
Copy link
Member

@ourigen partial support for this is added on tree-sitter branch. Here's how above content looks now:

screenshot

Bold is still a bit problematic because headlines start with * and it messes up the highlights.

@ourigen
Copy link
Contributor Author

ourigen commented Sep 12, 2021

Good to hear about the tree-sitter support! I'll help to test the branch when I have time

@kristijanhusak
Copy link
Member

@ourigen this should be working more less ok at this moment. Bold issue should also be fixed. Let me know.

@ourigen
Copy link
Contributor Author

ourigen commented Nov 28, 2021

@kristijanhusak Works well enough for me. Thanks for the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants