-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert control types constants into enums #10732
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I think there are two implementation strategies:
Performance wise, I'd do the former, but if you want to raise deprecation warnings, the latter is probably more effective. Have you also considered constants in oleacc.py? I'd leave them as is. |
An additional thought... May be we should advertise de labels using the enum itself?
|
Pushing this back to 2020.3 |
Given the possibility for breaking compatibility, I'm pushing this back to 2021.1 |
Rather than do this all in one go, instead, similar to "Use enum for speech reason #10703" first we'll do this in a backwards compatible way so that add-on authors have a transitionary period. Later, probably 2022.1 we'll remove the deprecated aspects. |
@feerrenrut - would the backwards compatible work be part of deprecations/2021.1 or should I start on this separately? |
@seanbudd the deprecation warnings don't necessarily need to be in this release. I think we should label this for 2022.1. The initial work to deprecate and provide a new alternative can be done after we get to beta for 2021.1. |
This issue stemmed from a comment in #10703
As a follow up, do the same for the rest of the constants in control types, and ensure that all of NVDA uses the enum versions and officially deprecate (and give a date of removal for) the module level constants.
While doing this, add a deprecation comment to SpeechReason constants also.
Originally posted by @feerrenrut in #10703
The text was updated successfully, but these errors were encountered: