Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: still traverse children when metainfo doesnt return object #469

Merged
merged 2 commits into from
Oct 9, 2019

Conversation

pimlie
Copy link
Collaborator

@pimlie pimlie commented Oct 8, 2019

Fixes: #468

@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #469 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #469      +/-   ##
========================================
+ Coverage   99.84%   100%   +0.15%     
========================================
  Files          33     33              
  Lines         659    657       -2     
  Branches      198    198              
========================================
- Hits          658    657       -1     
+ Misses          1      0       -1
Impacted Files Coverage Δ
src/shared/mixin.js 100% <ø> (+1.51%) ⬆️
src/shared/getComponentOption.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7404953...c466065. Read the comment docs.

@pimlie pimlie requested a review from a team October 8, 2019 15:19
@pimlie pimlie merged commit 35b7099 into master Oct 9, 2019
@pimlie pimlie deleted the fix-metainfo-return-undefined branch July 26, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debounceWait is not working as expected in universal mode
2 participants