feat(Table): add custom sort function to columns #1075
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Resolves #1071
β Type of change
π Description
This PR adds a
sortFn
property to table column objects. It takes a function as a value that will be used to compare items during the sorting of table rows. Defaults to the code that is currently used to compare values (<
,>
,===
). I have tested this new functionality in the playground.Docs have also been updated.
Note: this is my first real PR, so I'm open to any and all feedback on how to improve as a contributor! If the code smells, a better implementation could be made or I messed up with the creation of this PR, please feel free to say so π
π Checklist