Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settle on either undefined or null for async data's data and error #26295

Closed
3 of 4 tasks
DamianGlowala opened this issue Mar 16, 2024 · 2 comments · Fixed by #27294
Closed
3 of 4 tasks

Settle on either undefined or null for async data's data and error #26295

DamianGlowala opened this issue Mar 16, 2024 · 2 comments · Fixed by #27294
Assignees

Comments

@DamianGlowala
Copy link
Member

DamianGlowala commented Mar 16, 2024

Describe the feature

Currently, there is a discrepancy in default values of async data's data and error:

  • data is assigned an undefined value (unless a different default value is specified)
  • error is assigned a null value

It would be good to consider settling on one of them for consistency, unless there's a justifiable reason for why they have to differ.

Additional information

  • Would you be willing to help implement this feature?
  • Could this feature be implemented as a module?

Final checks

@DamianGlowala DamianGlowala moved this to Discussing in Team Board Mar 22, 2024
@danielroe danielroe moved this from Discussing to Approved in Team Board Mar 29, 2024
@danielroe
Copy link
Member

We will settle on undefined 🚀 🔥

@TheAlexLichter
Copy link
Member

To not forget: This might mean additional behavior changes for getCachedData() too, or an additional check for compat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Later
Development

Successfully merging a pull request may close this issue.

3 participants