Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HMR doesn't work for pages (3.0.0-rc.13) #15410

Closed
yura3d opened this issue Nov 8, 2022 · 3 comments · Fixed by nuxt/framework#8940
Closed

HMR doesn't work for pages (3.0.0-rc.13) #15410

yura3d opened this issue Nov 8, 2022 · 3 comments · Fixed by nuxt/framework#8940
Labels
3.x bug dx 🍰 p2-nice-to-have

Comments

@yura3d
Copy link

yura3d commented Nov 8, 2022

Environment

  • Operating System: Linux
  • Node Version: v16.14.2
  • Nuxt Version: 3.0.0-rc.13
  • Nitro Version: 0.6.1
  • Package Manager: npm@7.17.0
  • Builder: vite
  • User Config: -
  • Runtime Modules: -
  • Build Modules: -

Reproduction

https://stackblitz.com/edit/github-mwpzkm?file=app.vue,pages%2Findex.vue

Describe the bug

Any change made to files in pages directory causes to page reload.

But changes made to app.vue (for example) are applied through HMR correctly.

Additional context

No response

Logs

No response
@minkoonim
Copy link

god...
I thought it was my problem,
tried adding /removing all the plugins and packages to check what caused this for hours..

@minkoonim
Copy link

Just tried downgrading to rc12 and HMR works fine.

when upgrading back to latest (rc.14-27799862.1496d3a),
any change in pages will fully reload the whole app.

@danielroe
Copy link
Member

danielroe commented Nov 9, 2022 •
edited
Loading

Yes, this is likely a regression from nuxt/framework#8536.

@antfu antfu mentioned this issue Nov 12, 2022
Closed
7 tasks
antfu referenced this issue in nuxt/framework Nov 13, 2022
@antfu
fix(pages): improve HMR for macros, close #8820
9b6c662
@antfu antfu mentioned this issue Nov 13, 2022
Merged
7 tasks
@danielroe danielroe added the 3.x label Jan 19, 2023
@danielroe danielroe transferred this issue from nuxt/framework Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.x bug dx 🍰 p2-nice-to-have
Projects
None yet
Milestone
No milestone
3 participants
@yura3d @danielroe @minkoonim