Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bridge-vite: fonts are wrongly duplicating after build #492

Closed
AndreyYolkin opened this issue Aug 23, 2022 · 0 comments · Fixed by #480
Closed

bridge-vite: fonts are wrongly duplicating after build #492

AndreyYolkin opened this issue Aug 23, 2022 · 0 comments · Fixed by #480
Labels
pending triage

Comments

@AndreyYolkin
Copy link
Contributor

Environment

  • Operating System: Windows_NT
  • Node Version: v16.14.2
  • Nuxt Version: 2.16.0-27616340.013f051b
  • Package Manager: npm@8.16.0
  • Builder: vite
  • User Config: head, css, bridge, serverHandlers, devServerHandlers, buildModules
  • Runtime Modules: -
  • Build Modules: (), @nuxt/bridge@3.0.0-27672061.a645f7f

Reproduction

https://github.com/AndreyYolkin/nuxt-bridge-fonts-vite

You need to build and run project, dev mode is working as expected.

Describe the bug

When we are trying to connect font from package (@fontsource/ packages as example, also works with @mdi/font), vite-bridge generating fonts. That's ok, but in client[hash].js font urls are correct, but also generated HTML file contains the fonts in <head> with broken link, containing __NUXT_BASE__ in url.

We expect, that output files will have correct font urls. Also we expect, that fonts will not be loaded twice.

Additional context

image
image

Logs

No response
@AndreyYolkin AndreyYolkin changed the title bridge-vite: fonts are wrongly duplicated after build bridge-vite: fonts are wrongly duplicating after build Aug 23, 2022
@danielroe danielroe mentioned this issue Aug 23, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pending triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: migrate to vite 3 nuxt/bridge
1 participant
@AndreyYolkin