Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$t() autocomplete support #1753

Closed
2 of 4 tasks
EternalC0der opened this issue Dec 20, 2022 · 11 comments · May be fixed by intlify/vue-i18n#1649
Closed
2 of 4 tasks

$t() autocomplete support #1753

EternalC0der opened this issue Dec 20, 2022 · 11 comments · May be fixed by intlify/vue-i18n#1649
Assignees

Comments

@EternalC0der
Copy link

Describe the feature

Hello,
It would be really nice to have auto completion feature while using t('welcome') in template, especially when you want to reuse keys in different sections.

Additional information

  • Would you be willing to help implement this feature?
  • Could this feature be implemented as a module?

Final checks

Copy link
Collaborator

kazupon commented Dec 20, 2022

Hi!
I'll support about auto complete.
vue-i18n v9 has type-safe resources feature.
https://vue-i18n.intlify.dev/guide/advanced/typescript.html

we need to setup manually in vue-i18n.
In nuxt, I will support auto complete by respecting the defaultLocale and dynamically generating types with that resource as master schema.

I would also like to support $t, but we need to refactor the $t type definition on the vue-i18n side.
related issue on vue-i18n:
intlify/vue-i18n#1124

@jenseo
Copy link

jenseo commented Oct 10, 2023

@kazupon Any news on when we can expect this to be shipped? It would be a real step forward for developer experience in my opinion :)

@natemate90
Copy link

Any update on this?

@EternalC0der
Copy link
Author

I have been waiting for this feature for so long 😂
Any updates?

Here is a quick solution to get the list of locale keys, I wrote this to manually add type-safety for my code.
I hope it helps others:

import english from '~/i18n/en-US.json'

type StringKey<T> = Extract<keyof T, string>
type GenerateKeyPaths<T, Prefix extends string = ''> = T extends object
  ? { [K in StringKey<T>]: T[K] extends object ? GenerateKeyPaths<T[K], `${Prefix}${K}.`> : `${Prefix}${K}` }[StringKey<T>]
  : Prefix

type Locale = typeof english
export type I18nKeys = GenerateKeyPaths<Locale>

@Bobakanoosh
Copy link

@EternalC0der how are you using that? Are you making a custom translation function that then uses I18nKeys?

This works if we use t from useI18n

import "vue-i18n";
import en from "./i18n/website/en.json";

type MainTranslations = typeof en;
declare module "vue-i18n" {
	export interface DefineLocaleMessage extends MainTranslations {}
}

but it doesn't work with $t because the generated types for $t are incorrect. There's like 10 different overrides for it so I dont really want to override them all like above

@adamdehaven
Copy link

@kazupon I was able to get type-safe checking as well as auto-completion to work for the @nuxtjs/i18n $t function (and others) by manually overriding the interface for the given function(s).

I believe this could also be extended for type checking the methods exported like const { t } = useI18n() usage as well if implemented correctly.

I was going to attempt to PR the feature into the upstream repository; however, there appear to be around 19 different interfaces for the $t function in the resolved vue-i18n/dist/vue-i18n.d.ts file and I'm not sure where to start?

@thomaslecoeur
Copy link

Managed to get key autocompletion by adding a i18n.d.ts in my types folder (at root of project).

import fr from "~/i18n/fr";

type StringKey<T> = Extract<keyof T, string>;
type GenerateKeyPaths<T, Prefix extends string = ""> = T extends object
  ? {
      [K in StringKey<T>]: T[K] extends object
        ? GenerateKeyPaths<T[K], `${Prefix}${K}.`>
        : `${Prefix}${K}`;
    }[StringKey<T>]
  : Prefix;

type Locale = typeof fr;

declare global {
  type I18nKeys = GenerateKeyPaths<Locale>;
}

declare module "vue" {
  interface ComponentCustomProperties {
    $t(key: I18nKeys): string;
  }
}

#2591

@dsijakovski98
Copy link

dsijakovski98 commented Sep 20, 2024

Managed to get key autocompletion by adding a i18n.d.ts in my types folder (at root of project).

import fr from "~/i18n/fr";

type StringKey<T> = Extract<keyof T, string>;
type GenerateKeyPaths<T, Prefix extends string = ""> = T extends object
  ? {
      [K in StringKey<T>]: T[K] extends object
        ? GenerateKeyPaths<T[K], `${Prefix}${K}.`>
        : `${Prefix}${K}`;
    }[StringKey<T>]
  : Prefix;

type Locale = typeof fr;

declare global {
  type I18nKeys = GenerateKeyPaths<Locale>;
}

declare module "vue" {
  interface ComponentCustomProperties {
    $t(key: I18nKeys): string;
  }
}

#2591

Thanks! This helped me get the autocomplete working! 🙏
One small modification I made to make it work is, because I use .ts files with a default export:

// lang/en.ts
export default {
  welcome: "Welcome"
}

I had to change the config to

import type en from "./lang/en";

type StringKey<T> = Extract<keyof T, string>;
type GenerateKeyPaths<T, Prefix extends string = ""> = T extends object
  ? {
      [K in StringKey<T>]: T[K] extends object
        ? GenerateKeyPaths<T[K], `${Prefix}${K}.`>
        : `${Prefix}${K}`;
    }[StringKey<T>]
  : Prefix;

// IMPORTANT CHANGE HERE, USING AWAITED + RETURN TYPE
type Locale = Awaited<ReturnType<typeof en>>;

declare global {
  type I18nKeys = GenerateKeyPaths<Locale>;
}

declare module "vue" {
  interface ComponentCustomProperties {
    $t(key: I18nKeys): string;
  }
}

Also, remember to add the .d.ts file in your tsconfig.json file:

// tsconfig.json
{
 // ...

  "compilerOptions": {
    "types": ["./i18n.d.ts"]
  }
}

In case it helps anybody ✌️

@BobbieGoede
Copy link
Collaborator

The latest v9 release candidate (https://github.com/nuxt-modules/i18n/releases/tag/v9.0.0-rc.2) includes experimental vue-i18n options and messages generation, this provides autocompletion for translation functions, please try it out and let me know if this works as expected 🙏

More on the option that enables this functionality: https://i18n.nuxtjs.org/docs/v9/options/misc#experimentaltypedoptionsandmessages, the
PR implementing this has a demo video of it in action #3151

@BobbieGoede
Copy link
Collaborator

Closing this as we have experimental support for this in the stable release of v9, please try it out and let me know your thoughts!

@sneakylenny
Copy link

let me know your thoughts!

It works like a charm for me! Absolutely love it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants