replace Object.values #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
approved these changes
Aug 24, 2018
|
Thanks @eleith & Sorry for late merge |
|
Seem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
the package.json claims this module will run in node 6.*, however the code user
Object.valueshere: https://github.com/nuxt/webpackbar/blob/master/src/index.js#L32this will cause builds to fail in node 6.* environments because
Object.valuesis not supported.Additional Info
i didn't add any tests as the way to test this will require updating your circleci configurations to run tests in a node 6.* environment. i'm not familiar with the circle.yml and this could be added in a separate update