From 5b04b30b1365c5aae1f548ce63ddfffe82931e79 Mon Sep 17 00:00:00 2001 From: DraftMan Date: Wed, 23 Sep 2020 00:10:50 +0200 Subject: [PATCH 1/2] Relative path missing for the favicon The favicon must be accessible from any page and it does not matter how deep the page is. The only possible solution is to use a relative url. --- lib/meta/module.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/meta/module.js b/lib/meta/module.js index 97555957..28b2df3a 100755 --- a/lib/meta/module.js +++ b/lib/meta/module.js @@ -111,7 +111,7 @@ function generateMeta (pwa) { if (options.favicon && !find(this.options.head.link, 'rel', 'shortcut icon') && existsSync(favicon)) { console.warn('You are using a low quality icon, use icon png. See https://pwa.nuxtjs.org/icon/') - this.options.head.link.push({ rel: 'shortcut icon', href: 'favicon.ico' }) + this.options.head.link.push({ rel: 'shortcut icon', href: '/favicon.ico' }) } // Title From ae53b783f6db9375cb91f34bf96f4f60cbf522a0 Mon Sep 17 00:00:00 2001 From: pooya parsa Date: Thu, 1 Oct 2020 11:15:52 +0200 Subject: [PATCH 2/2] Update module.js --- lib/meta/module.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/meta/module.js b/lib/meta/module.js index 28b2df3a..401b193b 100755 --- a/lib/meta/module.js +++ b/lib/meta/module.js @@ -111,7 +111,7 @@ function generateMeta (pwa) { if (options.favicon && !find(this.options.head.link, 'rel', 'shortcut icon') && existsSync(favicon)) { console.warn('You are using a low quality icon, use icon png. See https://pwa.nuxtjs.org/icon/') - this.options.head.link.push({ rel: 'shortcut icon', href: '/favicon.ico' }) + this.options.head.link.push({ rel: 'shortcut icon', href: this.options.router.base + 'favicon.ico' }) } // Title