Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WARN] You are using a low quality icon, use icon png #341

Closed
pi0 opened this issue Sep 1, 2020 · 6 comments · Fixed by #363
Closed

[WARN] You are using a low quality icon, use icon png #341

pi0 opened this issue Sep 1, 2020 · 6 comments · Fixed by #363

Comments

@pi0
Copy link
Member

pi0 commented Sep 1, 2020

reported by @liyasthomas (#259 (comment) #259 (comment)) @thiscodes4u (#259 (comment)) and @zorca. It seems introduced by #258. Still didn't try to reproduce but seems a valid case or at least something not properly documented.

@pi0
Copy link
Member Author

pi0 commented Sep 1, 2020

/cc @ricardogobbosouza if you have any idea

@ricardogobbosouza
Copy link
Member

@pi0 problem on spa mode
https://github.com/nuxt-community/pwa-module/blob/master/lib/icon/module.js#L13
_emitAssets not called.

@ricardogobbosouza
Copy link
Member

Removing this line solves the problem
https://github.com/nuxt-community/pwa-module/blob/master/lib/meta/module.js#L11

@ricardogobbosouza
Copy link
Member

Is it okay to just run on the build: before hook?

@mtltechtemp
Copy link

any update on this guys?

@pi0
Copy link
Member Author

pi0 commented Oct 7, 2020

7a1e773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants