Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest cross-origin issues #18

Closed
simllll opened this issue Dec 6, 2017 · 1 comment
Closed

manifest cross-origin issues #18

simllll opened this issue Dec 6, 2017 · 1 comment

Comments

@simllll
Copy link
Contributor

simllll commented Dec 6, 2017

Hi all,
I ran into some troubles with the manifest json since I changed the publicPath to a cdn.
If i run lighthouse it complains about same-origin policy for the manifest file. Even though I found w3c/manifest#360 and it tunrs out cross origin should work just fine, the browser and several testing scenarios complain about it if the manifest is delivered by a different host.

I think it would be a easy fix if I can overwrite the publicPath within manifest module (I did the same for workbox ;), unfortantuly as I checked the source code of the manifest module I couldn't figure it out how to apply a different publicPath in this case.

Would be great to add an option to overwrite the public path, If you want me to I can create a PR and try to fix it up?

Thanks
Simon

Lighthouse report - 1 failed Audit:
User can be prompted to Install the Web App
Browsers can proactively prompt users to add your app to their homescreen, which can lead to higher engagement. Learn more.
Warnings: ERROR: start_url must be same-origin as document

This question is available on Nuxt.js community (#c11)
@simllll simllll changed the title manifest same-origin issues manifest cross-origin issues Dec 6, 2017
@pi0
Copy link
Member

pi0 commented Dec 6, 2017

Hey. I just didn't get the point but PRs welcome (And it would be 2x awesome if you can add some small docs about CDN usage). Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants