From 494eed5db00e7cf6863fc854e6ccb6b7bb8c0ba4 Mon Sep 17 00:00:00 2001 From: Ian Date: Tue, 6 Oct 2020 14:28:12 +0300 Subject: [PATCH] fix(meta): prevent build failure for ios splash image when no icon is used (#362) * fix(meta): check ios launch scren for undefined before accessing proprieties * feat(icon): display warning on console if the icon file was not found --- lib/icon/module.js | 2 ++ lib/meta/module.js | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/icon/module.js b/lib/icon/module.js index 76f67438..0570596a 100755 --- a/lib/icon/module.js +++ b/lib/icon/module.js @@ -63,6 +63,8 @@ async function run (pwa, _emitAssets) { // Disable module if no icon specified if (!options.source) { + // eslint-disable-next-line no-console + console.warn('[pwa] [icon] Icon not found in ' + path.resolve(this.options.srcDir, this.options.dir.static, options.fileName)) return } diff --git a/lib/meta/module.js b/lib/meta/module.js index 400c82dc..eeb26ba2 100755 --- a/lib/meta/module.js +++ b/lib/meta/module.js @@ -93,7 +93,7 @@ function generateMeta (pwa) { } // Launch Screen Image (IOS) - if (options.mobileAppIOS && !find(this.options.head.link, 'rel', 'apple-touch-startup-image')) { + if (options.mobileAppIOS && pwa._iosSplash && !find(this.options.head.link, 'rel', 'apple-touch-startup-image')) { this.options.head.link.push({ href: pwa._iosSplash.iphonese, media: '(device-width: 320px) and (device-height: 568px) and (-webkit-device-pixel-ratio: 2)', rel: 'apple-touch-startup-image' }) this.options.head.link.push({ href: pwa._iosSplash.iphone6, media: '(device-width: 375px) and (device-height: 667px) and (-webkit-device-pixel-ratio: 2)', rel: 'apple-touch-startup-image' }) this.options.head.link.push({ href: pwa._iosSplash.iphoneplus, media: '(device-width: 621px) and (device-height: 1104px) and (-webkit-device-pixel-ratio: 3)', rel: 'apple-touch-startup-image' })