-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tests structure #695
Comments
This should be ready to be worked on, because Jest 22.0.5 has that PR, and we're using 22.3.0 |
Leaving this here: https://www.npmjs.com/package/jest-codemods |
Is that smart enough for our purpose? It seems like it's used for migrating tests from other frameworks to Jest |
Just did a test and it seems that Flow libdef for Jest has not been updated to support this unfortunately. Let me see if I can make a PR for this. |
I just realized there is no need to write a codeshift to convert top level 'test' to 'describe'. We can just use regex. |
PR opened on flow-typed - flow-typed/flow-typed#1858 |
When jestjs/jest#5154 gets released, we should probably relook at our
describe
andtest
blocks. Some of them do not have a top leveldescribe
and phrasing is inconsistent across the various tests. This is a good chance to clean them up.Proposed format:
describe
with the component name that you are testing for.MyComponent.myMethod
.Feel free to add on to this. The purpose is to make them consistent across the code base.
The text was updated successfully, but these errors were encountered: