Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Going to definition prepends \\ to the file path in Windows #138

Closed
gaetschwartz opened this issue Jun 21, 2023 · 1 comment · Fixed by #141
Closed

Going to definition prepends \\ to the file path in Windows #138

gaetschwartz opened this issue Jun 21, 2023 · 1 comment · Fixed by #141

Comments

@gaetschwartz
Copy link
Contributor

When going to the definition of a user-defined command, the Windows path seems to not get parsed properly and the extension prepends \\ to paths like so: \\C:\foo\bar.nu which then fails to open.
@fdncred
Copy link
Contributor

fdncred commented Jun 21, 2023

interesting. we'd accept a PR to fix this. thanks for reporting it!

@gaetschwartz gaetschwartz mentioned this issue Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix go to definition on windows gaetschwartz/vscode-nushell-lang
2 participants
@fdncred @gaetschwartz