Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed feature is still referring to addressbook in DG #6010

Open
nus-se-script opened this issue Nov 17, 2023 · 1 comment
Open

Proposed feature is still referring to addressbook in DG #6010

nus-se-script opened this issue Nov 17, 2023 · 1 comment

Comments

@nus-se-script
Copy link

nus-se-script commented Nov 17, 2023

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.



This whole section is still based on addressbook, which is apparently a bug


[original: nus-cs2103-AY2324S1/pe-interim#5994] [original labels: type.DocumentationBug severity.VeryLow]
@Nixx162
Copy link
Contributor

Nixx162 commented Nov 18, 2023

Team's Response

Since our application and the original AB3 share a lot of common groundwork, it is perfectly OK for the section to still be there.

Apart from the unimplemented classes that support the proposed feature, all classes mentioned in the section are implemented both in AB3 and in our application (no rename refactors were made to preexisting classes).

Of course, the proposed feature regarding undo and redo still remains a perfectly valid feature to be implemented in our project.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment