Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement use of .runsettings file #133

Open
CharliePoole opened this issue Oct 24, 2016 · 8 comments
Open

Implement use of .runsettings file #133

CharliePoole opened this issue Oct 24, 2016 · 8 comments

Comments

@CharliePoole
Copy link
Contributor

Implement as for NUnit 3 adapter. Needed to support several other issues.

@CharliePoole CharliePoole added this to the 2.1 milestone Oct 24, 2016
@CharliePoole CharliePoole self-assigned this Oct 24, 2016
@OsirisTerje OsirisTerje modified the milestones: 2.1, 2.2 Mar 3, 2017
@Kanwar27
Copy link

Hi,
I am using Nuget package NunitTestAdapter vs2.1.1. Would it be possible to supply command line arguments specific to an assembly? Thanks

P.S. Forgive me if I posted the question at a wrong place.

@CharliePoole
Copy link
Contributor Author

@Kanwar27 If we implement this (see next paragraph) then it would have the same features as the NUnit 3 VS adapter, which includes parameters for use by your tests.

I'm taking this off the backlog for the moment and marking it for discussion. It's not clear if there will be a separate V2 adapter in the future or if the two adapters will be merged. There's no point in adding features to this one if it won't continue as a separate package.

@CharliePoole CharliePoole removed their assignment Apr 24, 2017
@Kanwar27
Copy link

Thanks for your reply.

Infering from coversation above I presume we would have something similar for Nunit in .runsettings file.

Would it be possible to provide debug args as we could do for nunit Gui?

Problem is we have multiple class library projects which are being run from Nunit console application. Switching to Nunit adapter leads me to loose ability for specifying "Debug" command line arguments.

P.S: I tried upgrading to nunit 3.x but couldn't because :

  • there is no gui for 3.x
  • some functions have been completely removed in 3.x. This reason would lead to so many changes.

If you could please give an example for providing debug command line args for nunit I might go through all botheration of changing functions manually.

Thanks and Regards
Kanwar

@rprouse
Copy link
Member

rprouse commented Apr 25, 2017

@Kanwar27 which functions have been removed in NUnit 3 that you rely on? The only major breaking change that most people complain about is the removed ExpectedException attribute and there are workarounds for that.

Also, if you are using the adapter in Visual Studio, why do you also need the GUI? Just trying to understand your workflow so we can prioritize work on the GUI. Have you tried the pre-release version of the GUI?

@Kanwar27
Copy link

@rprouse Thanks for providing workaround link. That, would help me to go to 3.x

Just need a way to pass Command line arguments inside Debug. Please refer to image below:
image. If I could do this in adapter would happily leave the GUI.

Regards
Kanwarpreet.

@CharliePoole
Copy link
Contributor Author

@Kanwar27 The option panel you are showing is part of Visual Studio, not the NUnit Gui. It has a space for setting the arguments of a program called "NUnitHost", which seems to be your own program. You can set the options for any executable you run, including nunit3-console.exe, if you choose to use that.

Perhaps it would be clearer for us if you indicated what kinds of options you want to set in the adapter by giving some examples.

@rprouse
Copy link
Member

rprouse commented Apr 25, 2017

@Kanwar27 if NUnitHost is your own NUnit test runner, as @CharliePoole said, you can do the same thing by setting Start external program in your test project (likely not NUnitHost) to the path to nunit3-console.exe and in the command line arguments, pass --inprocess path\to\yourtests.dll plus any other arguments that you need.

@M-Eber
Copy link

M-Eber commented Jul 16, 2018

Personally -- I'm all for having a single package that can work with NUnit 2 or NUnit 3.

@OsirisTerje OsirisTerje modified the milestones: 2.2, 2.3 Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants