Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NUNIT_ prefix for API_KEY environment variables #1296

Closed
Tracked by #1258
CharliePoole opened this issue Jan 7, 2023 · 1 comment
Closed
Tracked by #1258

Use NUNIT_ prefix for API_KEY environment variables #1296

CharliePoole opened this issue Jan 7, 2023 · 1 comment
Assignees
Milestone

Comments

@CharliePoole
Copy link
Collaborator

This issue was the cause of a failure in the releases of 3.16 and 3.16.1 from which I had to recover. It should be corrected in both the version3 and main branches to facilitate future work.

To retrieve Api Keys for pushing binaries, we use the following environment variables...

MYGET_API_KEY
NUGET_API_KEY
CHOCO_API_KEY

This works fine unless the developer is working on multiple projects, which use the same environment variables but need different values. That's what I was doing with NUnit and TestCentric. The problem arises in part because the above variables are used in online examples of Cake scripts.

This issue will replace the current variables with

NUNIT_MYGET_API_KEY
NUNIT_NUGET_API_KEY
NUNIT_CHOCO_API_KEY

For compatibility, we will fall back to the original environment variables if the new ones are not present.

@CharliePoole CharliePoole added this to the 3.16.2 milestone Jan 7, 2023
@CharliePoole CharliePoole self-assigned this Jan 7, 2023
@CharliePoole CharliePoole added the PortToVersion4 Version 3 change needs to be ported to the version 4 code in main label Jan 7, 2023
@CharliePoole CharliePoole removed the PortToVersion4 Version 3 change needs to be ported to the version 4 code in main label Jan 11, 2023
@CharliePoole
Copy link
Collaborator Author

This issue has been resolved in version 3.16.2

The release is available on:
GitHub.
NuGet packages are also available NuGet.org and
Chocolatey Packages may be found at Chocolatey.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant