Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue] Tap focus can't work #2167

Closed
sync-by-unito bot opened this issue Oct 7, 2022 · 22 comments
Closed

[issue] Tap focus can't work #2167

sync-by-unito bot opened this issue Oct 7, 2022 · 22 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Oct 7, 2022

User story

As a capture user, I want to tap on focus so that I can take a photo for the specific object I want smoothly.

Reproduce steps:

  1. open camera
  2. tap the point which you want to focus

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 1, 2022

➤ Sam commented:

Kenny Hung, can we move this task to the next sprint, please?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 1, 2022

➤ Kenny Hung commented:

Sam (Tammy Yang) okay, just remind this sprint also the quality is first, will move this to 1107 sprint.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 1, 2022

➤ Tammy Yang commented:

Yes, this sprint is still quality first ❤️

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 11, 2022

➤ Sam commented:

Kenny Hung, is this happening on iOS only?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 11, 2022

➤ Kenny Hung commented:

no, android will happen either.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 11, 2022

➤ Sam commented:

Dev status update.
Tried to tweak the parameters but can't see many changes.

Will publish changes in the next release if QA test for focusing fails I'm not sure how to make focusing work probably will need some native developers to assist.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 11, 2022

➤ Kenny Hung commented:

Sam Just wondering about camera focus, could we add some tips when user tap like these samples?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 11, 2022

➤ Sam commented:

Yes I was thinking about that too. I will try tomorrow 😇. Today I’m burn out with camera 😅

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 15, 2022

➤ Sam commented:

Kenny Hung I can not deliver this task in v221115. Might need to move to next sprint.

Next sprint I will be focusing on camera issues

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 15, 2022

➤ Kenny Hung commented:

Tammy Yang (cc Sam) because Sam doesn't deliver this task in this sprint, does this task drop or move to next sprint?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 15, 2022

➤ Tammy Yang commented:

ok, thx for your reminder

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 16, 2022

➤ Sam commented:

Kenny Hung, can I move it to next sprint?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 16, 2022

➤ Tammy Yang commented:

Yes, plz

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 17, 2022

➤ Sherry Chung commented:

According to feedback from Natalie Wang, lower the priority of this issue and raise the priority of [issue] zoom in/out should be zoom in a little when the slider bar just move a little bit ( https://app.asana.com/0/1201016280880500/1203175811194125/f ) instead.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 29, 2022

➤ Kenny Hung commented:

According to discuss from Comment by @sam on v221129-capture-app-ionic ( https://app.asana.com/0/0/1203376695669270/1203455819272863/f ), this task will be re-arrange.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 6, 2023

➤ Kenny Hung commented:

This task is medium, move to product backlog.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 6, 2023

➤ Sam commented:

Kenny Hung, it's not easy task so if I finish all critical tasks first I can look this task after.

@sync-by-unito sync-by-unito bot changed the title [issue] tap focus can't work smoothly [issue] tap focus can't work Jan 6, 2023
@sync-by-unito sync-by-unito bot changed the title [issue] tap focus can't work [issue] Tap focus can't work Jan 6, 2023
@sync-by-unito sync-by-unito bot closed this as completed Jan 27, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 27, 2023

➤ Sam commented:

Kenny Hung, v230131-capture-app-ionic ( https://app.asana.com/0/0/1203688155941323 ) will fix ✓ [issue] Tap focus can't work ( https://app.asana.com/0/0/1203120644372836 ) but we need to open another task for camera quality.

For example, I remember you can tap to focus but focus not focusing properly (Android).

Maybe we can create 2 separate tasks to ensure the camera can not only focus but focus properly.

  • [improvement] make sure android can focus properly on a selected object
  • [improvement] make sure iOS can focus properly on a selected object

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Feb 3, 2023

➤ Sam commented:

Scott Yan, can you please show demo of "not focusing very precisely on the selected object". I know this issue but I also want to see your testing case.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Feb 3, 2023

➤ Scott Yan commented:

OK I will record video & add it into improvement task

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Feb 8, 2023

➤ Kenny Hung commented:

Updated the test results for different devices.

  1. Pixel 5 can't work.
  2. Pixel 6 can't work.
  3. HTC exodus 1 can't work smoothly, need to tap a lot of times
  4. Samsung A21s could work.
  5. iPhone 8 could work.
  6. Oppo could work.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Feb 8, 2023

➤ Sam commented:

Kenny Hung thank you for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants