-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge GoPro multi-select upload #1400
Comments
➤ Ray Hung commented: Tammy YangScott Yan Let me know when we want to release this. |
➤ Tammy Yang commented: Ray Hung maybe the first week of April? |
➤ Tammy Yang commented: Ray Hung 此 task 請與 Bofu Chen 交接 |
➤ Ray Hung commented: Seems like these commits have already been merged. See https://dt42-numbers.slack.com/archives/C0323488MEJ/p1649236898644269 ( https://dt42-numbers.slack.com/archives/C0323488MEJ/p1649236898644269 ) |
➤ Bofu Chen commented: Ray Hung double checking with you:我們有完成 GoPro branch review 並過測嗎 上面 comment 的連結,James 說 "That's weird. I think these commits might be merged from one of the other pull request unintendedly" 看起來像是沒有人確定 GoPro feature 何時被 merge,以及是否有過測? |
➤ Scott Yan commented: multi-select upload 這個部分 QA 測試的是 sam 開發的版本 , 目前架上所有版本皆沒測試過這個項目 |
➤ Ray Hung commented: Bofu Chen Seems like someone, most likely James, has reviewed the code in this branch. But as you mentioned, we are not sure when these commits got merged. We weren't aware of it when it got merged accidentally. |
➤ Tammy Yang commented: ultanmyrza@numbersprotocol.io please help confirm if the PR has been merged |
➤ Sam commented: I checked from latest develop branch as of May 11 2022 (commit 320cae9 ( 320cae9 ))
are working. So I assume most important code is merged and this task can be considered as done. |
ruizehung 這個 branch 想請你幫忙處理
#1368
它是 GoPro multi-select upload ,已經通過一次 QA 測試和 code review ,需要麻煩你的事情是:
Created from Slack: https://dt42-numbers.slack.com/archives/C0323488MEJ/p1647935159614329
┆Issue is synchronized with this Asana task by Unito
┆Created By: Ray Hung
The text was updated successfully, but these errors were encountered: