Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge GoPro multi-select upload #1400

Closed
sync-by-unito bot opened this issue Mar 22, 2022 · 9 comments
Closed

Merge GoPro multi-select upload #1400

sync-by-unito bot opened this issue Mar 22, 2022 · 9 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Mar 22, 2022

ruizehung 這個 branch 想請你幫忙處理
#1368
它是 GoPro multi-select upload ,已經通過一次 QA 測試和 code review ,需要麻煩你的事情是:

  1. 確認何時要將此 feature 加入 release (請 scott & tammy 協助確認)
  2. resolve conflicts before merging, and merge when needed

Created from Slack: https://dt42-numbers.slack.com/archives/C0323488MEJ/p1647935159614329

┆Issue is synchronized with this Asana task by Unito
┆Created By: Ray Hung

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 22, 2022

➤ Ray Hung commented:

Tammy YangScott Yan Let me know when we want to release this.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 22, 2022

➤ Tammy Yang commented:

Ray Hung maybe the first week of April?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 4, 2022

➤ Tammy Yang commented:

Ray Hung 此 task 請與 Bofu Chen 交接

@sync-by-unito sync-by-unito bot closed this as completed Apr 6, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 6, 2022

➤ Ray Hung commented:

Seems like these commits have already been merged. See https://dt42-numbers.slack.com/archives/C0323488MEJ/p1649236898644269 ( https://dt42-numbers.slack.com/archives/C0323488MEJ/p1649236898644269 )

@sync-by-unito sync-by-unito bot reopened this Apr 6, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 6, 2022

➤ Bofu Chen commented:

Ray Hung double checking with you:我們有完成 GoPro branch review 並過測嗎

上面 comment 的連結,James 說 "That's weird. I think these commits might be merged from one of the other pull request unintendedly"

看起來像是沒有人確定 GoPro feature 何時被 merge,以及是否有過測?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 7, 2022

➤ Scott Yan commented:

multi-select upload 這個部分 QA 測試的是 sam 開發的版本 , 目前架上所有版本皆沒測試過這個項目

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 7, 2022

➤ Ray Hung commented:

Bofu Chen Seems like someone, most likely James, has reviewed the code in this branch. But as you mentioned, we are not sure when these commits got merged. We weren't aware of it when it got merged accidentally.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 26, 2022

➤ Tammy Yang commented:

ultanmyrza@numbersprotocol.io please help confirm if the PR has been merged

@sync-by-unito sync-by-unito bot closed this as completed May 11, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 11, 2022

➤ Sam commented:

I checked from latest develop branch as of May 11 2022 (commit 320cae9 ( 320cae9 ))
I confirm go pro related features like

  • ✅ connect to go pro from settings page
  • ✅ connect to go pro from custom-camera page (if connected previously)
  • ✅ multi-select upload
  • ✅ upload one by one
  • ✅ show go pro mobile data tutorial before upload

are working. So I assume most important code is merged and this task can be considered as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants