Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo to the App so users can know if there is caption or not #1170

Closed
sync-by-unito bot opened this issue Jan 10, 2022 · 10 comments
Closed

Add logo to the App so users can know if there is caption or not #1170

sync-by-unito bot opened this issue Jan 10, 2022 · 10 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Jan 10, 2022

User story:

As a user, I want to see a small icon overlayed on my Capture photos so that I know whether I have added captions for it or not.

┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 4, 2022

sultanmyrza@gmail.com commented:

here is the pull request #1506 ( #1506 )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 5, 2022

➤ Tammy Yang commented:

ultanmyrza@gmail.com can you please provide a screenshot for this?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 5, 2022

➤ Tammy Yang commented:

NVM, I saw it in the subtask. Thank you very much!

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 5, 2022

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 5, 2022

sultanmyrza@gmail.com commented:

I explained on pull request as well I’m just waiting for internal devs opinion 🤗

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 11, 2022

sultanmyrza@gmail.com commented:

Tammy Yang although I implemented dirty solution that seems working But if we do it right way it’s not that simple as it seems.

Here is the conversation from slack https://dt42-numbers.slack.com/archives/C0323488MEJ/p1649405695891169 ( https://dt42-numbers.slack.com/archives/C0323488MEJ/p1649405695891169 ) with James Chien discussing about its implementation

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 14, 2022

➤ Bofu Chen commented:

ultanmyrza@gmail.com I'm not sure if the attachment is the expectation of this feature.

I naively think that Capture will check if a Capture's caption is empty or not. If non-empty, then display the caption logo.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 14, 2022

sultanmyrza@gmail.com commented:

according to this comment ( #1506 (review) ) from James Chien this taks can be considered as done for now.

@sync-by-unito sync-by-unito bot closed this as completed Apr 14, 2022
@sync-by-unito sync-by-unito bot reopened this Apr 29, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 29, 2022

➤ Kenny Hung commented:

Sam On iOS 0.55.1 the logo doesn't display.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 29, 2022

➤ Kenny Hung commented:

Updated: I found when I re-open app, it could shows icon.

@sync-by-unito sync-by-unito bot closed this as completed Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants