Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] User should not be able to edit caption of asset they bought #1168

Closed
sync-by-unito bot opened this issue Jan 5, 2022 · 7 comments
Closed

[FR] User should not be able to edit caption of asset they bought #1168

sync-by-unito bot opened this issue Jan 5, 2022 · 7 comments
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Jan 5, 2022

problem story:
221209 updated:

  1. buy asset-origin: get asset directly -> can’t edit caption from press caption directly, but can edit caption from asset option button. (QA think it’s issue.)
  2. buy asset-clone: get license nft -> can edit caption by press caption or option button. (QA think it’s issue.)

購買來的可以使用 caption功能改原本創作者的 caption 後再上架 ,與 captureclub 設計有牴觸
When I'm a creator on CC&CaptureApp, when my product are sold, the next owner should can't edit caption.

Feature request:
購買來的 capture 不能修改原始創作者的 caption

User Story
As a capture app user, when I click the caption edit ( the capture was purchased ), I want to see not show the edit icon and can't edit caption .

┆Issue is synchronized with this Asana task by Unito
┆Created By: Scott Yan

@sync-by-unito sync-by-unito bot changed the title [FR] 購買來的 capture 不能修改 caption [FR] 購買來的 capture 不能修改原始創作者的 caption Jan 5, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 6, 2022

➤ Ray Hung commented:

As discussed last week during dev kick-off, more discussion is needed. Like whether we want to have caption be immutable in backend, or we just want to prevent user from editing the caption in Capture app

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 22, 2022

➤ Kenny Hung commented:

0.54.1尚未fixed this issue

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Dec 9, 2022

➤ Sherry Chung commented:

Kenny Hung (cc Scott Yan ) I think this related to current issue we discussed. Please wither merge them or rephrase

@sync-by-unito sync-by-unito bot changed the title [FR] 購買來的 capture 不能修改原始創作者的 caption [FR] User should not be able to edit caption of asset they bought Dec 9, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Dec 9, 2022

➤ Kenny Hung commented:

221209 updated

  1. buy asset-origin: get asset directly -> can’t edit caption from press caption directly, but can edit caption from asset option button. (QA think it’s issue.)
  2. buy asset-clone: get license nft -> can edit caption by press caption or option button. (QA think it’s issue.)

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Dec 25, 2022

➤ Tammy Yang commented:

Only

  1. Creator = owner
  2. Navigated from MyCapture page
  3. Source = original

Can edit capture

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Dec 26, 2022

➤ Kenny Hung commented:

QA think this issue is just fixed partly, it will be "conditional pass". Because another edit path is asset option button, that way still can edit the asset.
Continue tracking on [issue] "Collected" asset should not be edited the caption ( https://app.asana.com/0/1201016280880500/1203506811107492/f )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Dec 26, 2022

➤ Tammy Yang commented:

Kenny Hung Although, it is 100% correct that no matter the issue is related to Ionic part or iframe part, if the issue exists, it exists. QA should only look at "what users see". What you do is correct 👍

However, it is much easier for both QA and dev to track the status if we separate the Ionic and iframe parts. Because this issue depends to "iframe" release, it is clear that the task is associated to the iframe fix. In that case, I will consider this task as closed and only track [issue] "Collected" asset should not be edited the caption ( https://app.asana.com/0/1201016280880500/1203506811107492 ) for Ionic side. That may make our life easier 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant