Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default number of rows in Differences visualizer does not seem to work/match documentation #378

Closed
gwhitney opened this issue Jul 5, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@gwhitney
Copy link
Collaborator

gwhitney commented Jul 5, 2024

The "description" of the "Number of rows" parameter to the Differences visualizer states: "If zero, defaults to the length of top row". However, entering 0 results in an error message "Number of rows must be positive", and leaving it blank appears to default to the particular value 5, regardless of the length of the top row. The description and actual behavior should be chosen rationally and synchronized.

@gwhitney gwhitney added the bug Something isn't working label Jul 5, 2024
@gwhitney
Copy link
Collaborator Author

This appears to be working in ui2 now, presumably thanks to #420. The "Number of rows" parameter has no description, but starts empty with a greyed-out 12 in it, and indeed, shows 12 rows. Typing in a 0 results in the error message "Need at least one row" and any positive value produces the corresponding number of rows. Deleting the entry reverts to a greyed-out 12 and 12 rows shown. As all seems well, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant