Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error nodes on workspace folders which have no project.yml #25

Open
numaru opened this issue Jul 3, 2019 · 2 comments
Open

Remove error nodes on workspace folders which have no project.yml #25

numaru opened this issue Jul 3, 2019 · 2 comments
Labels
enhancement Improve an existing feature

Comments

@numaru
Copy link
Owner

numaru commented Jul 3, 2019

Hi,

Sorry for reopening a closed ticket, but I don't understand how this was fixed. I have a workspace with three folders (my source code in /src, some docs in /doc and the tests in /test). I keep them separated so I can get different c_cpp_settings.json for source and for tests, for example.
When I open the test explorer, I get two errors on the two workspaces that are not ceedling projects. How can I get rid of them?

image

I set the extension settings in the folder level, so only the test folder has the right path to the "project.yml" file (the other two have the default '.', and I think the extension is searching in /src and in /docs for a project.yml). As you said, it's better to get the error so the user can see that the problem comes from the extension is unable to get the settings, but maybe there should be a way to say "this folder doesn't contain one, that's why you can't find it, don't search".

Originally posted by @joel-felcana in #9 (comment)

@numaru
Copy link
Owner Author

numaru commented Jul 3, 2019

A proper solution could be a ceedlingExplorer.hasProject boolean option to tell the extension to search or not for a ceedling project in this workspace/folder.

@numaru numaru added the enhancement Improve an existing feature label Jul 3, 2019
@joel-felcana
Copy link

That would be brilliant, thanks for considering my suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants