Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolling Upgrade #561

Open
juliev0 opened this issue Feb 12, 2025 · 0 comments
Open

Rolling Upgrade #561

juliev0 opened this issue Feb 12, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@juliev0
Copy link
Collaborator

juliev0 commented Feb 12, 2025

Summary

Ideally, we'd have something more like a "canary" rollout:
Take down 1 Pod at a time (or x% of Pods at a time) and update scale.min on the upgrading one to correspond to what was removed on the other side. Perform this in a way such that the new Pod is brought up and confirmed to be healthy prior to the old one being taken down.

This gets a little tricky given that it means making multiple assessments. We currently have the idea of the "Assessment Window" for which we purposely wait 120 seconds prior to making that first assessment and then start the assessment. If there's any single failure in that window, we deem it failed.

Could we keep that one assessment start time, and basically continue to measure for the length of the progressive rollout and deem failure if there's ever any failure? We would need to make sure that there isn't a chance of an intermittent failed condition while new Pods are coming up.


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@juliev0 juliev0 added the enhancement New feature or request label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant