Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10 on ARM platform support #1134

Open
ghost opened this issue Jan 7, 2022 · 7 comments
Open

Windows 10 on ARM platform support #1134

ghost opened this issue Jan 7, 2022 · 7 comments
Labels
feature request This is a request for the addition of some feature. good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time.

Comments

@ghost
Copy link

ghost commented Jan 7, 2022

Platform:
Windows 10 on ARM64 (19044.1415)
Nuclear version:
/
Description of the issue:
No available version of nuclear is compatible with Windows 10 on ARM
Windows 10 on arm supports the following executables:

  • 32bit x86
  • ARM64

Would it be possible to provide a build for this platform ?

@ghost ghost added the bug This issue identifies a bug in Nuclear. label Jan 7, 2022
@nukeop
Copy link
Owner

nukeop commented Jan 7, 2022

We use electron-builder, and I don't see such a configuration option: https://www.electron.build/configuration/win#WindowsConfiguration-target

@ghost
Copy link
Author

ghost commented Jan 8, 2022

I found this https://www.electron.build/cli and this electron-userland/electron-builder#5558.
I don't really understand whats going on but i added the --arm64 flag to the windows build script. The build looked good initially but failed later on my side because i was builing on a linux ARM64 host which seems unsupported by electron-builder.

output:

  • writing effective config  file=release/builder-effective-config.yaml
  • rebuilding native dependencies  dependencies=sqlite3@4.2.0 platform=win32 arch=arm64
  • packaging       platform=win32 arch=arm64 electron=12.2.2 appOutDir=release/win-arm64-unpacked
  ⨯ cannot execute  cause=exit status 123
                    errorOut=it looks like wine32 is missing, you should install it.
    as root, please execute "apt-get install wine32"

@ghost
Copy link
Author

ghost commented Jan 8, 2022

Never mind, i found the folder release\win-arm64-unpacked after the build.
The release inside works on my machine.

@nukeop
Copy link
Owner

nukeop commented Jan 8, 2022

Nice, then in this case this should only be the matter of adding a flag to the build action so we can generate one more artifact.

@nukeop nukeop added feature request This is a request for the addition of some feature. and removed bug This issue identifies a bug in Nuclear. labels Jan 23, 2022
@ArminiusTux
Copy link

Just kicking the can further down the road.

@nukeop nukeop added the good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time. label Nov 25, 2023
@nukeop
Copy link
Owner

nukeop commented Nov 25, 2023

This would need to be a little bit more involved: https://github.com/marketplace/actions/run-on-architecture
We'd need a separate build step to build on arm64, and then include it in the final list of windows binaries.

@nukeop
Copy link
Owner

nukeop commented Aug 6, 2024

There is now a separate mac arm64 build so it should be pretty easy to do the same for windows too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request This is a request for the addition of some feature. good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time.
Projects
None yet
Development

No branches or pull requests

2 participants