Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace obsolete BinaryFormatter #1247

Closed
wants to merge 1 commit into from
Closed

Replace obsolete BinaryFormatter #1247

wants to merge 1 commit into from

Conversation

cristipufu
Copy link

@cristipufu cristipufu commented Aug 31, 2023

Tried to update to net8.0:

I confirm that the pull-request:

  • Follows the contribution guidelines
  • Is based on my own work
  • Is in compliance with my employer

@nsentinel
Copy link

I think maybe we should not introduce a new external dependency in the form of Newtonsoft.Json and implement by using System.Text.Json - https://learn.microsoft.com/en-us/dotnet/standard/serialization/system-text-json/migrate-from-newtonsoft?pivots=dotnet-7-0.

@cristipufu
Copy link
Author

@matkoch can you please take a look? is there something I can help with to speed up the update?

@cristipufu
Copy link
Author

net8-rc1 has been released

@dkogithub
Copy link

Hi @nsentinel, @cristipufu we are very waiting for this also :)

@cristipufu
Copy link
Author

@matkoch kind reminder

@cristipufu
Copy link
Author

FYI as a workaround you can add <EnableUnsafeBinaryFormatterSerialization>true</EnableUnsafeBinaryFormatterSerialization> in .csproj

@ErisApps
Copy link
Contributor

ErisApps commented Oct 3, 2023

I might be mistaken, but I think you might have accidentally changed the encoding of the non-generated files in this PR.

@matkoch
Copy link
Member

matkoch commented Nov 19, 2023

Thanks for the PR, but unfortunately it's not working. I decided to suppress the warning for now and approach the issue in a year again.

@matkoch matkoch closed this Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants