Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDSS magnitude naming inconsistency, Bu2019lm grid #317

Closed
bfhealy opened this issue Feb 7, 2024 · 1 comment
Closed

SDSS magnitude naming inconsistency, Bu2019lm grid #317

bfhealy opened this issue Feb 7, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@bfhealy
Copy link
Collaborator

bfhealy commented Feb 7, 2024

The current grid of lightcurves used to train Bu2019lm (last updated to include the ultrasat filter) contains a different SDSS magnitude naming convention (e.g. sdss__u) than the sncosmo filters (e.g. sdssu).

Additionally, the Bu2019lm.pkl file on gitlab currently only contains the ultrasat filter key. Updating the file on gitlab without inducing downstream errors will require a new grid of lightcurves that has SDSS magnitudes in the sncosmo filter format.

This could be a useful test case for the model grid update workflow (#302).
@bfhealy bfhealy added the bug Something isn't working label Feb 7, 2024
@bfhealy bfhealy mentioned this issue Feb 8, 2024
Closed
@bfhealy
Copy link
Collaborator Author

bfhealy commented Mar 7, 2024

This has now been addressed on Gitlab. Note that Zenodo has been deprecated by #290.

@bfhealy bfhealy closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bfhealy