Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failures in VS2010 #106

Open
rtollert opened this issue Nov 18, 2024 · 1 comment
Open

Build failures in VS2010 #106

rtollert opened this issue Nov 18, 2024 · 1 comment

Comments

@rtollert
Copy link

1>------ Build started: Project: taglib, Configuration: Release Win32 ------
1>cl : Command line warning D9002: ignoring unknown option '/Qvec-report:1'

/Qvec-report appears to have only been added in VS2015.

1>c:\users\rtollert\src\qaac\taglib\toolkit\tpropertymap.h(34): warning C4231: nonstandard extension used : 'extern' before template explicit instantiation
1>....\taglib\toolkit\tpropertymap.cpp(193): error C2960: 'TagLib::Map<Key,T>' : inconsistent explicit instantiations, a previous explicit instantiation specified 'extern template'

2>C:\Users\rtollert\src\qaac\taglib\ogg\xiphcomment.h(40): warning C4231: nonstandard extension used : 'extern' before template explicit instantiation
2>....\input\LibSndfileSource.cpp(204): error C2039: 'make_unique' : is not a member of 'std'

C++14-ism?

Am I correct to intuit that the minimum compiler requirement is actually (at least) VS2015 nowadays?

@nu774
Copy link
Owner

nu774 commented Nov 18, 2024

Release files are currently built with MSVC2013, and that may be the lowest version.
TagLib started to use C++17 on version 2 which apparently is not supported by MSVC2013
And I'm wondering whether we should also move on and require C++17 or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants