Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsqd: deflate level specified from client lib in IDENTIFY not work #926

Closed
DoraALin opened this issue Aug 14, 2017 · 1 comment · Fixed by #927
Closed

nsqd: deflate level specified from client lib in IDENTIFY not work #926

DoraALin opened this issue Aug 14, 2017 · 1 comment · Fixed by #927
Labels

Comments

@DoraALin
Copy link

DoraALin commented Aug 14, 2017

Greetings,
Upon identify with specified deflate level, nsqd does not accept it but using max deflate level in option.

in IDENTIFY(), identifyData.Deflate does not used to decide the deflate level, is it a bug here?
line #396, protocol_v2.go
deflate := p.ctx.nsqd.getOpts().DeflateEnabled && identifyData.Deflate deflateLevel := 0 if deflate { if identifyData.DeflateLevel <= 0 { deflateLevel = 6 } deflateLevel = int(math.Min(float64(deflateLevel), float64(p.ctx.nsqd.getOpts().MaxDeflateLevel))) }

besides, there is a typo in attribute of client connection in nsqadmin, when deflate apply.
image

@mreiferson
Copy link
Member

see #927

@mreiferson mreiferson changed the title deflate level specified from client lib in IDENTIFY not work nsqd: deflate level specified from client lib in IDENTIFY not work Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants