You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Greetings,
Upon identify with specified deflate level, nsqd does not accept it but using max deflate level in option.
in IDENTIFY(), identifyData.Deflate does not used to decide the deflate level, is it a bug here?
line #396, protocol_v2.go deflate := p.ctx.nsqd.getOpts().DeflateEnabled && identifyData.Deflate deflateLevel := 0 if deflate { if identifyData.DeflateLevel <= 0 { deflateLevel = 6 } deflateLevel = int(math.Min(float64(deflateLevel), float64(p.ctx.nsqd.getOpts().MaxDeflateLevel))) }
besides, there is a typo in attribute of client connection in nsqadmin, when deflate apply.
The text was updated successfully, but these errors were encountered:
mreiferson
changed the title
deflate level specified from client lib in IDENTIFY not work
nsqd: deflate level specified from client lib in IDENTIFY not work
Aug 14, 2017
Greetings,
Upon identify with specified deflate level, nsqd does not accept it but using max deflate level in option.
in IDENTIFY(), identifyData.Deflate does not used to decide the deflate level, is it a bug here?
line #396, protocol_v2.go
deflate := p.ctx.nsqd.getOpts().DeflateEnabled && identifyData.Deflate deflateLevel := 0 if deflate { if identifyData.DeflateLevel <= 0 { deflateLevel = 6 } deflateLevel = int(math.Min(float64(deflateLevel), float64(p.ctx.nsqd.getOpts().MaxDeflateLevel))) }
besides, there is a typo in attribute of client connection in nsqadmin, when deflate apply.
The text was updated successfully, but these errors were encountered: